Attention is currently required from: Andrey Pronin, Christian Walter, Yi Chou, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 )
Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()`
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71885/comment/d68eeb4d_8a6783cc
PS2, Line 10: and
an?
File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/71885/comment/ec61a269_a9e903ee
PS2, Line 84: /**
/*
File src/security/tpm/tss/tcg-2.0/tss_structures.h:
https://review.coreboot.org/c/coreboot/+/71885/comment/8edc4ef4_3aff9f74
PS2, Line 328: uint16_t size;
Is there a need to use a fixed-length data type, or could it be `unsigned int`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79455b3ee73c265a9e4bf3d8b9c6562490efbf1c
Gerrit-Change-Number: 71885
Gerrit-PatchSet: 2
Gerrit-Owner: Yi Chou
yich@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Yi Chou
yich@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 08:33:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment