Attention is currently required from: HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44207 )
Change subject: src/include: Clean up some includes
......................................................................
Patch Set 12:
(2 comments)
File src/include/cpu/x86/legacy_save_state.h:
https://review.coreboot.org/c/coreboot/+/44207/comment/dd19433e_ca900d7f
PS12, Line 6: stdint.h
chain included by types.h […]
Keep <types.h>
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/44207/comment/4e6ef49c_fd0ebbaf
PS12, Line 6: commonlib/bsd/cb_err.h
chain included through <types.h>. […]
Keep <types.h> please.
At some point I want to replace the type-unsafe set_option/get_option API and will need <types.h>.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44207
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69c4d21273c9fb400449fd39274f15c0be013402
Gerrit-Change-Number: 44207
Gerrit-PatchSet: 12
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 03 Feb 2021 10:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment