Jude Rich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37939 )
Change subject: utils/kconfig/nconf.c: Fix truncation warning in `item_add_str`
......................................................................
Patch Set 3:
Patch Set 2:
(3 comments)
Hello Jude, thanks for your patch. Do you intend to upstream it
to Linux? Also, I'm curious, is this fixing an actual issues or
is it only about cosmetics?
Hello, Niko. Thank you for the review. Your points were all valid,
so I made the changes. I don't believe there was a bug here, it's
mainly about cleaner code.
As for upstreaming to Linux, I'll have to do that. It hadn't
occurred to me that they were the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb2dfad7e401954f4bb83d0409ab71dcd7277f47
Gerrit-Change-Number: 37939
Gerrit-PatchSet: 3
Gerrit-Owner: Jude Rich
juder11@gmail.com
Gerrit-Reviewer: Jude Rich
juder11@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jan 2020 17:21:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment