Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36546 )
Change subject: soc/intel/icelake: Make use of "all-y"
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36546/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36546/1//COMMIT_MSG@7
PS1, Line 7: to avoid exclusive stage files in Makefile.inc
Minor: I would remove this last part to make the commit summary shorter
Done
https://review.coreboot.org/c/coreboot/+/36546/1/src/soc/intel/icelake/Makef...
File src/soc/intel/icelake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36546/1/src/soc/intel/icelake/Makef...
PS1, Line 22: espi
Is it bad to add some more files like espi.c, gpio.c memmap.c p2sb. […]
also shouldn't we try to limit the files inclusion in stages unless required ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11001d0d381ec9c1df41bc331da845f51e666a44
Gerrit-Change-Number: 36546
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Sat, 02 Nov 2019 02:16:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment