Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33190 )
Change subject: soc/intel/icelake: Replace PCI device LPC to ESPI as per EDS
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Looks good to me.
https://review.coreboot.org/#/c/33190/4/src/soc/intel/icelake/include/soc/es...
File src/soc/intel/icelake/include/soc/espi.h:
https://review.coreboot.org/#/c/33190/4/src/soc/intel/icelake/include/soc/es...
PS4, Line 19: #include <stdint.h>
Thanks for pointing out this miss. […]
Oh, this is because of "indirect header inclusion".
If the files which include <espi.h> also include <stdint.h> beforehand, the compiler already knows about <stdint.h> and doesn't complain.
But this is very fragile: unrelated changes to other files can make the compiler complain about this file all of a sudden.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4990ea6d9b7b4c0eac2b3eea559f5469f086e827
Gerrit-Change-Number: 33190
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Jun 2019 14:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment