Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )
Change subject: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively ......................................................................
Patch Set 2:
(9 comments)
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 131: PAD_CFG_NF(GPP_F11,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 133: PAD_CFG_NF(GPP_F12,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 135: PAD_CFG_NF(GPP_F13,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 137: PAD_CFG_NF(GPP_F14,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 139: PAD_CFG_NF(GPP_F15,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 141: PAD_CFG_NF(GPP_F16,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 143: PAD_CFG_NF(GPP_F17,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 145: PAD_CFG_NF(GPP_F18,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/35204/1/src/mainboard/google/hatch/... PS1, Line 147: PAD_CFG_NF(GPP_F19,UP_20K, DEEP, NF1),
space required after that ',' (ctx:VxV)
Done