Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32613 )
Change subject: payloads/external/Memtest86Plus: update to version 002 stable
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
any objections here? if they tag, we should follow, shouldn't we?
I guess them is us ;) but that tag comment doesn't say anything
about `stable`. Maybe wait if Martin (R.) has something to say
about it.
https://review.coreboot.org/c/coreboot/+/32613/1/payloads/external/Memtest86...
File payloads/external/Memtest86Plus/Makefile:
https://review.coreboot.org/c/coreboot/+/32613/1/payloads/external/Memtest86...
PS1, Line 18: TAG-$(CONFIG_MEMTEST_STABLE)=0bd34c22604660e4283316331f3e7bf8a3863753
why not make it obvious and write `v002`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2
Gerrit-Change-Number: 32613
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Kepplinger
martink@posteo.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Kepplinger
martink@posteo.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Jul 2019 00:09:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment