Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub ......................................................................
Patch Set 6:
(5 comments)
Fixed issues.
https://review.coreboot.org/c/coreboot/+/38743/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38743/5//COMMIT_MSG@11 PS5, Line 11: Sandybridge
Sandy Bridge
Fixed with patchset 6.
https://review.coreboot.org/c/coreboot/+/38743/5//COMMIT_MSG@14 PS5, Line 14: ROM
VBIOS, rather
Fixed with patchset 6.
https://review.coreboot.org/c/coreboot/+/38743/5//COMMIT_MSG@15 PS5, Line 15: With patches
With what patches? Did you mean: […]
Clarified on patchset 6.
https://review.coreboot.org/c/coreboot/+/38743/5//COMMIT_MSG@17 PS5, Line 17: Windows 10 1909 also tested but generates bluescreen once GPU : driver is loaded.
It's likely looking for ACPI mandatory functions like _DOD, _DSS, ... […]
Here's a dump of both stock and corebooted (with this patch applied) DSDTs for this board, both with the dGPU enabled.
https://gist.github.com/macromorgan/640addff8577ec732efcb610ee0a00a6
https://review.coreboot.org/c/coreboot/+/38743/5/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/pcie.c:
https://review.coreboot.org/c/coreboot/+/38743/5/src/northbridge/intel/haswe... PS5, Line 83: 0 };
This fits on the previous line
Fixed in patchset 6.