Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68955 )
Change subject: [WIP] soc/amd/common: Add header info for STB prints to console ......................................................................
[WIP] soc/amd/common: Add header info for STB prints to console
The STB data being printed to the console wasn't clearly identified. - Add which stage the data is being printed in. - Add a header row to better explain the data.
TEST=Build tested only
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I368d20cb617cfefb1721a207925571064907f4d4 --- M src/soc/amd/common/block/stb/stb.c 1 file changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/68955/1
diff --git a/src/soc/amd/common/block/stb/stb.c b/src/soc/amd/common/block/stb/stb.c index 0cea5c3..6865b77 100644 --- a/src/soc/amd/common/block/stb/stb.c +++ b/src/soc/amd/common/block/stb/stb.c @@ -51,8 +51,16 @@ return; }
- if (i == 0) - printk(BIOS_DEBUG, "Available Smart Trace Buffer data:\n"); + if (i == 0) { + const char *str = " Timestamp | Value |"; + printk(BIOS_DEBUG, "Available %s Smart Trace Buffer data:\n", + ENV_STRING); + printk(BIOS_DEBUG, "Ofst|%s%s%s%s\n", str, + STB_ENTRIES_PER_ROW >= 2 ? str : "", + STB_ENTRIES_PER_ROW >= 3 ? str : "", + STB_ENTRIES_PER_ROW >= 4 ? str : ""); + } + if ((i % STB_ENTRIES_PER_ROW) == 0) printk(BIOS_DEBUG, "%04d,", i); printk(BIOS_DEBUG, " 0x%08x,0x%08x, ", stb_val.ts, stb_val.val);