Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73216 )
Change subject: mb/google/brya/acpi: Remove extra DC boost byte ......................................................................
mb/google/brya/acpi: Remove extra DC boost byte
The DC boost bit was intended to be in the Controller Params word rather than its own byte. Correct this error.
BUG=b:214581372 TEST=build
Change-Id: Ie65e57a351f0fc1f0c80ef320fd87043ee22916c Signed-off-by: Tarun Tuli taruntuli@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/73216 Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/brya/acpi/nvpcf.asl 1 file changed, 22 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/acpi/nvpcf.asl b/src/mainboard/google/brya/acpi/nvpcf.asl index 501b94c2..9f6c5e1 100644 --- a/src/mainboard/google/brya/acpi/nvpcf.asl +++ b/src/mainboard/google/brya/acpi/nvpcf.asl @@ -34,7 +34,7 @@ 2=CTGP-only. [7:4] Reserved. Set to 0. */ /* Controller #1 Params */ - 0x00, /* Class = Dynamic Boost + /* Class = Dynamic Boost [0:0] DC support 0=Not supported, 1=Supported [31:1] Reserved. Set to 0. */