build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 44:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/fc2e7905_52bd5a64 PS44, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/306e6617_aca4006f PS44, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/78c5402d_757605af PS44, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7024cc3a_b5960b6c PS44, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6ae83fe2_a5e75498 PS44, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/49d475c9_90f7fa23 PS44, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d2b270d3_85607e17 PS44, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/655ca4cd_d6825b45 PS44, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/39e95ac1_1f5c7234 PS44, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e1a5c3a7_5f2bcfa1 PS44, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b02ec634_29cbd7f7 PS44, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8c5e7196_99caf500 PS44, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a2523d1c_a0d9dd15 PS44, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cf86b8b4_3bf9b3a8 PS44, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/94871b02_fea25691 PS44, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e7089a92_3550e642 PS44, Line 315: floppy_verifier "fiwix" "d6c0af72afe6bf100ee2a0bf67128253fb0260bd0bbeaac707d90191f7a2c361" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a45a478e_a47bdec4 PS44, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c6e0935e_35a142fe PS44, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ccb9ef1d_ce567cce PS44, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cc64c8c8_5c7fb99c PS44, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7a44c559_f846905f PS44, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f71ab9fe_de951ac9 PS44, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f1fabbf6_3588af09 PS44, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1b4bb2d0_48dd6f1a PS44, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/113218b5_011983fa PS44, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/880d0f8c_539bc9a8 PS44, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/015869e4_7add31db PS44, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/625ebf01_59fa890d PS44, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d758d497_28d8953b PS44, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/011e03ab_021f196b PS44, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ff83327b_b1362fe4 PS44, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0f27672b_e2493f71 PS44, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/25f06e6f_1ed34cce PS44, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/be3093fa_fea7f04a PS44, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/15b06907_cfb26e05 PS44, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/778585a1_0a07ead7 PS44, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/08191bef_03d37caf PS44, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a3b229e8_98c9e558 PS44, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b15f4f0a_94f386ef PS44, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f03daa8a_5388ff79 PS44, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/eb222225_37dde242 PS44, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/10381465_8cd52a55 PS44, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/14480265_75117d93 PS44, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/68357979_44fd752d PS44, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a16454fe_2e550079 PS44, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d3f4ff55_7b6db412 PS44, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dd664c7b_9ec323de PS44, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/db3e7f99_bca2c49c PS44, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0c25e51a_ca698629 PS44, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a6dd3f00_91d65f94 PS44, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/96205f29_9eb91ebd PS44, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b1b8caa5_9ef4baea PS44, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a4b7bc9a_71eff43e PS44, Line 781: csb_patcher "dgpu" "39873" "7" "4c4aaf8" "461ffa6134cee13cdf7afcfd81bd42ccd39db4f835cf32950143e9f96e829869" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b0789161_1ecd9d92 PS44, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/844dfa6d_82bec572 PS44, Line 791: csb_patcher "irq" "48427" "3" "663dfc6" "20002afd94c101b4c3385d3c1c4042653c44f9394938e004b3c36de83f556216" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1401bd54_5ced6ccb PS44, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/17a8f748_645d61a6 PS44, Line 801: csb_patcher "seabios" "32351" "11" "02b4028" "2c712fa64430afc836504bd6c9ee4c785d09ef5c282e7a55c52e71a5e26d24e3" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c3d2255d_1117fc89 PS44, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4d9e6772_ef80a39e PS44, Line 811: csb_patcher "config.lenovo_g505s" "32352" "35" "6bdd8e7" "2f9090d1a7d9b6bc6515ab4aa9dbbe2bb9f195474aa5ec85e0aceda5305f7993" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/74a2835d_5fdc4b2c PS44, Line 816: csb_patcher "config.asus_am1i-a" "33800" "22" "2731fd9" "e3da0a38f78f441350939ea1f7acb7b249c915be7a2d3bf55dc49ab86a6cc855" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dd86b3dd_7a18cafa PS44, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "9" "daac703" "b653fad480d914759160000e42c6e8c766524f83dfa5154c1ae7c2b458daee02" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/76dd0035_5d763438 PS44, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/18dbaa1a_fe973b31 PS44, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/04e25cd2_a46a007d PS44, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b1a86e40_39f3a858 PS44, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/228520b6_cc4ca591 PS44, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters