Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34446 )
Change subject: mainboard/facebook/fbg1701: Add VBT binary
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1...
File src/mainboard/facebook/fbg1701/Kconfig:
https://review.coreboot.org/c/coreboot/+/34446/3/src/mainboard/facebook/fbg1...
PS3, Line 30: select INTEL_GMA_ADD_VBT
try "select INTEL_GMA_HAVE_VBT" then you don't have to specify the VBT path.
Does not work on fsp1.1 using RUN_FSP_GOP also. Function load_vbt is not available.
This function (file vbt.c) will be included through src/drivers/intel/fsp1_1/Makefile.inc when INTEL_GMA_ADD_VBT is enabled only.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If327e4e071df61b02fcec45213c2b700320ef269
Gerrit-Change-Number: 34446
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 05:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment
