Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )
Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................
Patch Set 5:
(3 comments)
Marking comments as Done, maybe that will make the build go?
https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... PS1, Line 83: 14
got it. I got my device today so I may be able to take a look tomorrow. […]
Done
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 78: 3
Yes, though it seems like 2 should be fine here, so I'll change to that, and add stop_off_delay_ms o […]
Done
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 80: 12
I noticed most of the other users of GDIX0000 seem to have this padding. […]
Done