4 Jan
2021
4 Jan
'21
5:49 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49060 )
Change subject: mb/clevo/kbl-u: Rework Kconfig ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/49060/1/src/mainboard/clevo/kbl-u/K... File src/mainboard/clevo/kbl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/49060/1/src/mainboard/clevo/kbl-u/K... PS1, Line 22: _OPTIONS
same as on cml-u, I'd drop that suffix, since it's not really needed or useful
as on cml: the linter prevents that. let's revisit later
--
To view, visit https://review.coreboot.org/c/coreboot/+/49060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f07b5851ece6d0943faa9c90fc518805880a27d
Gerrit-Change-Number: 49060
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Daniel Maslowski info@orangecms.org
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Mon, 04 Jan 2021 16:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment