Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36781 )
Change subject: nb/intel/sandybridge: Make the mainboard_rcba_config hook optional
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36781/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36781/1//COMMIT_MSG@9
PS1, Line 9: late
Nice one. Makes it visible that some things in the mb code are actually
run too late (e.g. hiding P2P bridge so the MRC doesn't scan it).
https://review.coreboot.org/c/coreboot/+/36781/1/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/pch.h:
https://review.coreboot.org/c/coreboot/+/36781/1/src/southbridge/intel/bd82x...
PS1, Line 75: callback
Bothered me more and more, everytime I see it...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36781
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1897d0f5ca7427d304a425f5256cd43c088ff936
Gerrit-Change-Number: 36781
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 17 Nov 2019 13:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment