Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29830 )
Change subject: mb/google/sarien/variants/sarien: Enable melf touchscreen
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants...
PS2, Line 124: GPP_B13
According schematic, the reset_gpio is connected with PLTRST. […]
This pin is going to get pulsed by the kernel when sequencing power to the touchscreen, and we don't want it pulsing PLTRST and taking the whole system down.
This may need to just have the power GPIO and not the reset GPIO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I926c988c141628ae2d98206f9eb615d06357a366
Gerrit-Change-Number: 29830
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Crystal Lin
crystal_lin@compal.corp-partner.google.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 01 Dec 2018 01:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment
