Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58065 )
Change subject: mb/prodrive/hermes: Fix PCIe ClkSrc configuration
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58065/comment/8a62a0fb_bb6ffff2
PS2, Line 10: Apparently, FSP does not turn off unused PCIe clock sources when using
Yes, the ClkSrc configuration in FSP UPDs is wrong. […]
Ah! Now I got it 😄 Yes, I guess it's not necessary since wrong values is reason enough for fixing it :-)
https://review.coreboot.org/c/coreboot/+/58065/comment/7fa36c2d_935885fa
PS2, Line 12: firmware.
I changed the CSME IFD to match the SPS IFD (and devicetree) and now all PCIe devices show up. […]
erm, that change is required, bc the UPDs are plain wrong
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id25a34816f512510640db95251a7a792c1eebe62
Gerrit-Change-Number: 58065
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 04 Oct 2021 18:09:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment