Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45627 )
Change subject: superio/common: Fix NULL pointer dereferences
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45627/2/src/device/device_util.c
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/45627/2/src/device/device_util.c@52...
PS2, Line 525: if (resource->flags & IORESOURCE_PCI_BRIDGE) {
I'd place the check here:
if (dev->link_list && (resource->flags & IORESOURCE_PCI_BRIDGE)) {
This way, we still print the other information.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I953a6524fff509a7833896392b25a3245c8cd705
Gerrit-Change-Number: 45627
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Sep 2020 11:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment