Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39720 )
Change subject: nb/intel/sandybridge: Store CPUID in ctrl struct
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39720/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/39720/1/src/northbridge/intel/sandy...
PS1, Line 299: err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size);
If the CPU was replaced, but the DIMMs were not, this would be called with the wrong information. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39720
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ac435fb83900a52890f823e7614055061299e23
Gerrit-Change-Number: 39720
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 21 Mar 2020 21:49:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment