[coreboot-gerrit] Change in ...coreboot[master]: sdm845: Add GPIO IRQ APIs

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30003 )

Change subject: sdm845: Add GPIO IRQ APIs
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/30003/11/src/soc/qualcomm/sdm845/gpio.c 
File src/soc/qualcomm/sdm845/gpio.c:

https://review.coreboot.org/#/c/30003/11/src/soc/qualcomm/sdm845/gpio.c@90 
PS11, Line 90: 	clrsetbits_le32(&regs->intr_cfg, GPIO_INTR_RAW_STATUS_ENABLE
Please combine into a single access:

clrsetbits_le32(&regs->intr_cfg,
                 GPIO_INTR_DECT_CTL_MASK << GPIO_INTR_DECT_CTL_SHIFT,
                 type << GPIO_INTR_DECT_CTL_SHIFT |
                 GPIO_INTR_RAW_STATUS_ENABLE << GPIO_INTR_RAW_STATUS_EN_SHIFT);