build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46566 )
Change subject: mb/google/zork: Fix get board version and get fw config issue ......................................................................
Patch Set 1:
(12 comments)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 60: if (google_chromeec_cbi_get_fw_config(&known_value) !=0) { spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 98: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 114: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 139: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 64: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dalboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 50: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dirinboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 39: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 84: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 72: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/trembyle/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 63: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 28: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/woomax/gpio.c:
https://review.coreboot.org/c/coreboot/+/46566/1/src/mainboard/google/zork/v... PS1, Line 63: if (google_chromeec_cbi_get_board_version(&board_version) !=0) spaces required around that '!=' (ctx:WxV)