26 Aug
2019
26 Aug
'19
6:46 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35099 )
Change subject: what-jenkins-does: keep essential artifacts arounds ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35099/1/util/testing/Makefile.inc File util/testing/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35099/1/util/testing/Makefile.inc@9... PS1, Line 91: COREBOOT_BUILD_DIR=coreboot-builds-chromeos would prefer usage of `-o`, so the command still comes first
https://review.coreboot.org/c/coreboot/+/35099/1/util/testing/Makefile.inc@9... PS1, Line 93: ; find any reason not to start a new recipe line here with `-find`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ca5cb84ab1bcffbc92a972980cd0769ebf02462
Gerrit-Change-Number: 35099
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Aug 2019 16:46:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment