Attention is currently required from: Ravi kumar, Furquan Shaikh, Arthur Heymans, Prasad Malisetty.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 )
Change subject: libpayload: Add support for PCI MMIO CONFIG access.
......................................................................
Patch Set 32: Verified-1
(2 comments)
File payloads/libpayload/drivers/qc_pci_mmio_ops.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143140):
https://review.coreboot.org/c/coreboot/+/57615/comment/a19fe8d9_fa027237
PS32, Line 107: cfg_address = (void*) pci_mmio_info->config_base;
"(foo*)" should be "(foo *)"
File payloads/libpayload/include/qc_pci.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143140):
https://review.coreboot.org/c/coreboot/+/57615/comment/83c9bf7f_1731644b
PS32, Line 70: #endif
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57615
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d1217502cbd7d4d0cdd298919ae82435630d61c
Gerrit-Change-Number: 57615
Gerrit-PatchSet: 32
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 19:40:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment