Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44588 )
Change subject: mb/google/dedede/var/boten: Add LTE power on/off sequence ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded... PS10, Line 11: 1
LCFC will go on testing this CL. Tracking issue: https://partnerissuetracker.corp.google. […]
Based on the latest comment in the bug, setting it to 0 as the init state.
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded... PS10, Line 45: 1
I think ACPI still not validation if set value equal 0 in here.
Based on further verification, setting it to 0 as the init state.
https://review.coreboot.org/c/coreboot/+/44588/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/variant.c:
https://review.coreboot.org/c/coreboot/+/44588/9/src/mainboard/google/dedede... PS9, Line 39: power_off_lte_module(slp_typ);
Since we have register "reset_off_delay_ms" = "10" in overridetree. […]
Yes, _OFF method is not invoked from the kernel. For now we need it. Once it is fixed in kernel, we can remove it.