[coreboot-gerrit] [M] Change in coreboot[main]: util/amdfwtool: Add binary parsing

[Felix Held (Code Review)]

Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Marshall Dawson, Maximilian Brune, Paul Menzel.

Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email )

Change subject: util/amdfwtool: Add binary parsing
......................................................................

Patch Set 8:

(1 comment)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/84373/comment/8129c3a3_da005fa2?usp... :
PS8, Line 263: { .type = AMD_FW_MINIMSMU, .subprog = 0, .level = PSP_BOTH | PSP_LVL2_AB },
             : 	{ .type = AMD_FW_MINIMSMU, .subprog = 1, .level = PSP_BOTH | PSP_LVL2_AB },
> Dropping "Instance" seems like it could potentially be a problem.

this adds the inst=0, subprog=1 case, but drops the inst=1, subprog=0 case