Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45482 )
Change subject: payloads/external: add support for BOOTBOOT payload
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45482/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45482/2//COMMIT_MSG@8
PS2, Line 8:
Oh, I see! I've updated the commit message with a brief description, and also provided a link for th […]
You could add some more less obvious information. For instance, I was
happy to see that you based it on libpayload. My next question would
be from where / how you load the kernel? given that there are no file-
system drivers in libpayload and the BOOTBOOT descriptions says it is
out of scope. This particular implementation however, has to do it some
way and I'm very curious :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45482
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8692cde0730338026a7760a293c1e37f66004bc0
Gerrit-Change-Number: 45482
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Baldaszti
bztemail@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 17:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zoltan Baldaszti
bztemail@gmail.com
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment