Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/25871
Change subject: soc/amd/stoneyridge/gpio.c: Fix gpio_output() ......................................................................
soc/amd/stoneyridge/gpio.c: Fix gpio_output()
Function gpio_output() is only setting the pin as an output, when in fact it should also set the state (high/low) of the pin. Fix the procedure to set the state of the pin.
BUG=b:78328773 TEST=None
Change-Id: I516192a0782a9bbb40124029f264a2711114c800 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/soc/amd/stoneyridge/gpio.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/25871/1
diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c index 088f199..4520df7 100644 --- a/src/soc/amd/stoneyridge/gpio.c +++ b/src/soc/amd/stoneyridge/gpio.c @@ -95,6 +95,7 @@ reg = read32((void *)gpio_address); reg |= GPIO_OUTPUT_ENABLE; write32((void *)(uintptr_t)gpio_num, reg); + gpio_set(gpio_num, value); }
const char *gpio_acpi_path(gpio_t gpio)