5 Jan
2020
5 Jan
'20
12:24 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38179 )
Change subject: drivers/pc80/rtc: Clean up some inlined functions ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... File src/include/pc80/mc146818rtc.h:
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... PS1, Line 138: if (control_state & RTC_SET) wasn't obvious on the first sight
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... PS1, Line 155: cmos_enable_rtc(); should only be enabled if it was running before cmos_disable_rtc was called()
--
To view, visit https://review.coreboot.org/c/coreboot/+/38179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie73797b4e9a09605a0685f0b03cb85e9a3be93ad
Gerrit-Change-Number: 38179
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 05 Jan 2020 08:24:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment