Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51751 )
Change subject: soc/amd/cezanne: add add_chipset_state_cbmem()
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51751/comment/23c4dec4_73d33f95
PS3, Line 9: Guybrush complains that this is missing during the boot, so add it to
: cezanne.
This is required to ensure that the chipset state is stashed before anything else (FSP) overwrites i […]
No - Nothing complained about that being missing, so I didn't see it. I'll go look for it.
File src/soc/amd/cezanne/romstage.c:
https://review.coreboot.org/c/coreboot/+/51751/comment/c189f955_b5fdb016
PS3, Line 16: mainboard_updm_update
Unrelated change.
Thanks, I didn't notice that I'd grabbed that too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3de3764c99fe89b962db88065575463b365ddaf5
Gerrit-Change-Number: 51751
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 27 Mar 2021 14:50:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment