Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 50:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 39: default BOARD_ASUS_A88XM_E_DDR3_VOLT_150
XMP support has been successfully added to opensource AGESA ;-) Please see the topic:"AMD_XMP" chang […]
Balazs, should we just remove these voltage options?
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 104: * Untested: HDMI
Then this means something was copypasted without understanding what it does. Not resolved.
Could this commit clarify? https://github.com/coreboot/coreboot/commit/7f23aeb05d57d4989783b35afce0017d... If it's appropriate, DP2 port might be actually for a "Mini-DDI card" (what is it, by the way?)