Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43155 )
Change subject: sb/intel/i82801{gx,ix,jx}/acpi: Align cosmetics
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43155/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43155/1//COMMIT_MSG@7
PS1, Line 7: sb/intel/i82801{gx,ix,jx}/acpi: Align cosmetics
Unify alignment […]
I use "align" whenever I change things so that the diffstat is smaller. I would use "unify" whenever I actually merge things together, like CB:39737 or https://review.coreboot.org/q/topic:%22unify_hp_laptops"
When I extract a common piece of code, I use "factor out"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43155
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If49bad776ebc98cab439f8ea6942471520c476a3
Gerrit-Change-Number: 43155
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Jul 2020 13:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment