Divya Sasidharan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM)
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c...
PS2, Line 1460: PD_CC_DFP_ATTACHED
I will have to verify why it was done this way with Divya
ACK. This above check is fine as it is to see if DFP or UFP is attached.
Although for below change we need to include for UFP case as well PD_CC_UFP_DEBUG_ACC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If994a459288ef31b0e6da8c6cdfd0ce3a0303981
Gerrit-Change-Number: 42078
Gerrit-PatchSet: 3
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 13 Jul 2020 17:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment