Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36770 )
Change subject: mb/asrock/b85m_pro4: Add new mainboard
......................................................................
Patch Set 12:
(1 comment)
Patch Set 12: Code-Review+2
(1 comment)
Thanks!
https://review.coreboot.org/c/coreboot/+/36770/12/src/mainboard/asrock/b85m_...
File src/mainboard/asrock/b85m_pro4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36770/12/src/mainboard/asrock/b85m_...
PS12, Line 29: pirqa_routing
probably defaulting just to 11 is a better idea but this outside the scope of this patch.
I used the values from vendor, but I'll check if they are actually needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a16dfc56f2aa88648c8aaaba4feab40c491504
Gerrit-Change-Number: 36770
Gerrit-PatchSet: 12
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Comment-Date: Thu, 19 Mar 2020 09:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment