[coreboot-gerrit] [M] Change in coreboot[master]: soc/qualcomm/common: Add sdhci_msm_init function

[Shelley Chen (Code Review)]

Attention is currently required from: mturney mturney, Julius Werner, Sudheer Amrabadi.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72634 )

Change subject: soc/qualcomm/common: Add sdhci_msm_init function
......................................................................

Patch Set 3:

(2 comments)

File src/soc/qualcomm/common/include/soc/sdhci_msm.h:

https://review.coreboot.org/c/coreboot/+/72634/comment/051ccc2e_f7fe6e0d 
PS2, Line 54: #define CMDIN_RCLK_EN		(1 << 1)
> I don't think we need all of these definitions?

Yeah, you're right.  I'll clean out the ones that we're not using.

File src/soc/qualcomm/common/storage/sdhci_msm.c:

https://review.coreboot.org/c/coreboot/+/72634/comment/ed8f6905_29c50a07 
PS2, Line 64: 	if (host == NULL)
> I think this can be simplified to a one-liner.

Done