Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63541 )
Change subject: arch/x86/postcar_loader: Correct off-by-one of MTRR end address in log
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63541/comment/40390ea4_ee28ddb2
PS2, Line 12: wrong
It's not wrong. Originally, the start address is inclusive and the end address is exclusive. […]
Thanks Angel. I wasn't aware of the other places but it makes sense to me having all of them consistently. I will refactor and provide a new version of this CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63541
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ca292f9cf272564cb5ef1c4ea38f5c483605c94
Gerrit-Change-Number: 63541
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 10:05:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment