Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42652 )
Change subject: sb/intel/i82801gx/fadt.c: Align with i82801ix ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42652/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/fadt.c:
https://review.coreboot.org/c/coreboot/+/42652/1/src/southbridge/intel/i8280... PS1, Line 38: /* Upper word is reserved and : Linux complains about 32 bit. */
Origins of the comment: https://review.coreboot.org/1691 […]
Looks like ICH7 uses 18 bits... ICH9 14... ACPI specifies 14 of the 16-bit minimum.
Can't remember what Linux complained about, ofc. But a quick look suggests:
/* * If a valid register (Address != 0) and the (default_length > 0) * (Not a GPE register), then check the width against the default. */
from `drivers/acpi/acpica/tbfadt.c:661`. The default is 16 bits.
So I guess while it is technically not wrong to set `len > 2`, the comment seems true.