Attention is currently required from: Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47148?usp=email )
Change subject: acpi: Call acpi_fill_ssdt() only for enabled devices
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/47148/comment/c2f2a111_6d78757d :
PS1, Line 235: if (!dev->enabled)
: return;
:
IIUC, this is because the AMD UART device is using a hybrid approach of using raw ASL as well as acp […]
i had some out of band discussion with Matt and i'd say that CB:77092 is the best feasible solution that doesn't have significant side effects
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47148?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib042bec7e8c68b38fafa60a8e965d781bddcd1f0
Gerrit-Change-Number: 47148
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 08 Aug 2023 16:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan.m.shaikh@gmail.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
inforichland@gmail.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment