Attention is currently required from: Ashish Kumar Mishra, Bora Guvendik, Saurabh Mishra, Wonkyu Kim.
Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79900?usp=email )
Change subject: soc/intel/common: Add lunarlake device IDs ......................................................................
Patch Set 2:
(5 comments)
Patchset:
PS2: All the comments are resolved
File src/soc/intel/common/block/spi/spi.c:
https://review.coreboot.org/c/coreboot/+/79900/comment/01fb2faf_d1298382 : PS1, Line 126: PCI_DID_INTEL_LNL_HWSEQ_SPI,
other platform just added GSPI.
Acknowledged. Moved to to the correct file.
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/79900/comment/903f0572_fd2e114f : PS1, Line 318: case PCI_DID_INTEL_LNL_UART0:
Could you move to line 312? Latest platform should be first.
Acknowledged
https://review.coreboot.org/c/coreboot/+/79900/comment/550289d0_3d661d6b : PS1, Line 326:
Could you move to line 312? Latest platform should be first.
Acknowledged
https://review.coreboot.org/c/coreboot/+/79900/comment/ecefb862_c69ff467 : PS1, Line 334:
Could you move to line 312? Latest platform should be first.
Acknowledged