Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86650?usp=email )
Change subject: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86650/comment/55e7b024_d66b8db4?usp... :
PS1, Line 9: GPP_H08 and GPP_H09 are configured in the bootblock, so remove the
: configuration in ramstage.
is there any benefit to not doing so?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86650?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4b813370cf259fb1ca138dd1922c16f801b40cc4
Gerrit-Change-Number: 86650
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 28 Feb 2025 13:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes