Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38388 )
Change subject: soc/intel/{apl,cnl,icl,skl,tgl}: Add comments for above 4GB mem range macro
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38388/1/src/soc/intel/apollolake/in...
File src/soc/intel/apollolake/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/38388/1/src/soc/intel/apollolake/in...
PS1, Line 68: * Length is 2^36 = 64 GB.
Forgive me for being dense, but this base and length are the upper end of TOUUD (base in this case). […]
i understand what your mean Aaron but how do i write the same is my confusion :(
Do you think a diagram might help in comment section ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38388
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe812031ea91932ec63adb030541b5ab5db8f425
Gerrit-Change-Number: 38388
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jan 2020 05:00:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment