Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39894 )
Change subject: tests: Add build subsystem for unit testing coreboot
......................................................................
Patch Set 4: Code-Review+1
OK, now +1 is actually meant for this CL.
And same reasoning for +1 vs. +2 applies as on the other CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0220b84b9a6e448476ca3eb3ccccc5fb829ad1
Gerrit-Change-Number: 39894
Gerrit-PatchSet: 4
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Apr 2020 15:22:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment