Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33421 )
Change subject: util/superiotool/nuvoton.c: add NCT5539D register dump ......................................................................
Patch Set 12: Code-Review+1
(2 comments)
Just a few nits here and there, but at least the hex values look good.
https://review.coreboot.org/#/c/33421/12/util/superiotool/nuvoton.c File util/superiotool/nuvoton.c:
https://review.coreboot.org/#/c/33421/12/util/superiotool/nuvoton.c@587 PS12, Line 587: {0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x22,0x24,0x25,0x26,0x27,0x28,0x2a, : 0x2b,0x2c,0x2d,0x2f,EOT}, Please split this in two lines that are similarly long.
Same thing for the other long lines.
https://review.coreboot.org/#/c/33421/12/util/superiotool/nuvoton.c@638 PS12, Line 638: Led LED