Attention is currently required from: Nico Huber, Paul Menzel, Iru Cai (vimacs).
Pablo Stebler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44750 )
Change subject: ec/hp/kbc1126: Wait a longer time after sending
......................................................................
Patch Set 9:
(1 comment)
File src/ec/hp/kbc1126/Kconfig:
https://review.coreboot.org/c/coreboot/+/44750/comment/b1bb66a4_65506a4a
PS8, Line 14: int "Maximum waiting time in ms after sending a command to the EC"
Why does this need a prompt? Generally, those encourage downstream solutions, […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8623af75c062d6aa69d4412e0627d426c69019fb
Gerrit-Change-Number: 44750
Gerrit-PatchSet: 9
Gerrit-Owner: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Comment-Date: Sun, 31 Jan 2021 15:35:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment