Bhanu Prakash Maiya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44421 )
Change subject: mb/google/zork: Use FW_CONFIG to enable/disable eMMC on Dalboz
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44421/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/dalboz/variant.c:
https://review.coreboot.org/c/coreboot/+/44421/2/src/mainboard/google/zork/v...
PS2, Line 199: * unprovisioned boards.
same line?
Ack
https://review.coreboot.org/c/coreboot/+/44421/2/src/mainboard/google/zork/v...
PS2, Line 202: boot_is_factory_unprovisioned()) {
same line
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa2a49a754d85fb6269f788c970bd9da58af1dad
Gerrit-Change-Number: 44421
Gerrit-PatchSet: 3
Gerrit-Owner: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 20:42:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment