Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37490 )
Change subject: soc/amd/picasso: Add bootblock support
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi...
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi...
PS13, Line 48: config HAVE_BOOTBLOCK
Removing this just means we no longer create an empty bootblock.bin: https://source.chromium. […]
Right, instead of an empty bootblock.bin you now get full-featured non-XIP bootblock.elf at end of coreboot.rom, with RESET_VECTOR_IN_RAM=y.
Logically, the parent commit (implement RESET_VECTOR_IN_RAM) should be the implementation for a non-XIP bootblock. The non-XIP bootblock at end of coreboot.rom is simply no longer valid there, it is not linked to execute from MMIO/SPI flash memory and also contains sections that must be writable.
It's probably a two or three liner patch to fix it in the parent, but go ahead and file a bug on it instead with the parent commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37490
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d0784025f2b39f140b16f37726d4a7f36df6c6c
Gerrit-Change-Number: 37490
Gerrit-PatchSet: 14
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 18:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment