Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39040 )
Change subject: soc/intel/tigerlake: add DDR4 support
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39040/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39040/3//COMMIT_MSG@9
PS3, Line 9: Add Rcomp data structure in meminit to support updating rcomp resistor
: and target values for DDR4 support.
Where is the SoC code that uses this information?
Will create a function like meminit_ddr4x() in soc, currently it was done inline in fsp_params.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3858cc56c838862fc61123c8b7dba11dbc40983c
Gerrit-Change-Number: 39040
Gerrit-PatchSet: 4
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 22 Feb 2020 00:58:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment