Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40830 )
Change subject: [WIP]security/intel: Add option to eanble SMM flash access only ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Tested on Skylake. Relevant patches that I have applied include the parent of this change, but as `fast_spi_pr_dlock` completes, I guess it isn't relevant.
https://review.coreboot.org/c/coreboot/+/40830/1/src/soc/intel/common/pch/lo... File src/soc/intel/common/pch/lockdown/lockdown.c:
https://review.coreboot.org/c/coreboot/+/40830/1/src/soc/intel/common/pch/lo... PS1, Line 66: if (CONFIG(BOOTMEDIA_SMM_BWP)) { Placing debug prints throughout this function shows that boots are failing before executing/completing `fast_spi_set_eiss`.