Attention is currently required from: John Zhao, Brandon Breitenstein.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48630 )
Change subject: drivers/intel/usb4: Enable retimer FW upgrade mux interaction
......................................................................
Patch Set 7:
(1 comment)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/48630/comment/3c34ed9c_65d32f67
PS6, Line 108: const char *RFWU = "\_SB_.PCI0.LPCB.EC0_.RFWU";
What about a __weak function to retrieve the ACPI path to this RFWU byte as it's been defined? something like `const char *mainboard_retimer_fw_update_path(void)` ?
for chromeos, since it's related to the EC, we could define a non-weak version of the function somewhere in ec/google/chromeec
Thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I768cfb56790049c231173b0ea0f8e08fe6b64b93
Gerrit-Change-Number: 48630
Gerrit-PatchSet: 7
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Comment-Date: Thu, 07 Jan 2021 17:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment