Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30506 )
Change subject: sb/intel/common: Remove CAR_GLOBAL use ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/30506/6/src/southbridge/intel/common/gpio.c File src/southbridge/intel/common/gpio.c:
https://review.coreboot.org/#/c/30506/6/src/southbridge/intel/common/gpio.c@... PS6, Line 44: if (gpiobase) At some point before POSTCAR_STAGE=y, this would have failed without car_get_var() stuff around it. But probably romstage after raminit did not play with GPIOs so we never caught the error.
https://review.coreboot.org/#/c/30506/6/src/southbridge/intel/common/pmbase.... File src/southbridge/intel/common/pmbase.c:
https://review.coreboot.org/#/c/30506/6/src/southbridge/intel/common/pmbase.... PS6, Line 44: static u16 pmbase; Like previous file.