Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44905 )
Change subject: mb/google/puff: Convert ASL file to new DPTF dt impl
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44905/9/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/9/src/mainboard/google/hatch/...
PS9, Line 279: 90
The first number in each pair should have remained the same: 50, 47, 45, 42, 39.
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/faffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/...
PS8, Line 289:
Done
In addition, not replacing. It was policies.passive[1] for a reason.
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/...
PS8, Line 292:
Done
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45987f44ec381917173f8d2a878edb50da454b4b
Gerrit-Change-Number: 44905
Gerrit-PatchSet: 9
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 31 Aug 2020 10:18:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment